tag:support.markedapp.com,2011-09-11:/discussions/problems/143798-critic-markup-visibility-for-dark-themesMarked: Discussion 2020-12-23T01:53:35Ztag:support.markedapp.com,2011-09-11:Comment/441190982017-11-24T17:55:45Z2017-11-24T17:55:45ZCritic markup visibility for dark themes<div><p>Thanks for pointing this out, I'll look into it for the next update.</p></div>Bretttag:support.markedapp.com,2011-09-11:Comment/441190982017-11-24T18:17:04Z2017-11-24T18:17:04ZCritic markup visibility for dark themes<div><p>Updated all of the colors for inverse modes, thanks again. Hadn't caught this before!</p>
<p><img src="http://ckyp.us/xe77Q+" alt=""></p></div>Bretttag:support.markedapp.com,2011-09-11:Comment/441190982017-11-24T18:33:30Z2017-11-24T18:34:19ZCritic markup visibility for dark themes<div><p>Hi Brett,<br>
great!<br>
Difficult to catch 100% of the issues; could you please have a look at syntax highlighting as well?<br>
E.g. Upstanding Citizen seems to have problems with code syntax (see my screenshot)</p>
<p>Thanks again.</p></div>johsebtag:support.markedapp.com,2011-09-11:Comment/441190982017-11-24T18:35:18Z2017-11-24T18:35:18ZCritic markup visibility for dark themes<div><p>Yep, I'll fix that as well.</p></div>Bretttag:support.markedapp.com,2011-09-11:Comment/441190982018-05-11T00:55:09Z2018-05-11T00:55:09ZCritic markup visibility for dark themes<div><p>Brett,<br>
sorry to bother you with small details but here's a follow-up on Critic Markup styling:</p>
<p>Highlights are OK but Comments didn't change and still have, in my opinion, sub-optimal readability on dark themes. Comments are OK on light themes (see screenshot4). I think the best solution could be to adopt an orange background with black text for both dark and light themes (similar to what have been done for Highlights).</p>
<p>Also, looking at you 24 Nov screenshot it seems that the green used for Additions are now lighter; it's OK on dark themes but maybe a little too bright for light themes (see screenshot).</p>
<p>Thanks,<br>
Pierpaolo</p></div>johsebtag:support.markedapp.com,2011-09-11:Comment/441190982018-05-11T01:55:31Z2018-05-11T01:55:31ZCritic markup visibility for dark themes<div><p>Thanks for the update. I think some of my styling changes might have gotten lost in a git branch, I'll track them down for the next update.</p></div>Bretttag:support.markedapp.com,2011-09-11:Comment/441190982018-05-11T15:08:41Z2018-05-11T15:08:41ZCritic markup visibility for dark themes<div><p>Are you sure you don't have any custom styles overriding mine? When I went int to start editing, my markup did not look like yours, but more like the screenshots I had posted earlier. I did go ahead and make some tweaks, though:</p>
<p><strong>Swiss - Standard mode</strong></p>
<p><img src="http://ckyp.us/MxN3ov+" alt=""></p>
<p><strong>Swiss - High Contrast</strong></p>
<p><img src="http://ckyp.us/lxC6qC+" alt=""></p></div>Bretttag:support.markedapp.com,2011-09-11:Comment/441190982018-05-11T19:32:25Z2018-05-11T19:32:25ZCritic markup visibility for dark themes<div><p>The light theme was a custom style but the dark one (high contrast) was the standard Swiss style that comes with the app.<br>
But indeed you're right: markups in your preview (some of them at least) look different from mines.<br>
I will try to completely unistall the app and then do a fresh installation.</p></div>johsebtag:support.markedapp.com,2011-09-11:Comment/441190982018-05-11T19:44:03Z2018-05-11T19:44:03ZCritic markup visibility for dark themes<div><p>Before you do that, let me clarify that the screenshots I just posted<br>
are from my very newly-modified stylesheets, not released yet.</p>
<p>-Brett</p></div>Bretttag:support.markedapp.com,2011-09-11:Comment/441190982018-05-11T21:31:32Z2018-05-12T09:31:06ZCritic markup visibility for dark themes<div><p>OK so I'll wait and check the modified stylesheets in the next release.</p>
<p>Update: solved in rel 2.5.13 (946)</p>
<p>Thanks.</p></div>johseb